GSoC/GCI Archive
Google Code-in 2010 MoinMoin Wiki

refactor views render calls

completed by: Julian Brost

mentors: Alexander Schremmer, ReimarBauer, Thomas Waldmann, Ronny Pfannschmidt

Abstract

Several views have multiple render calls - if POST fails, normally you just want to render as it was GET (plus posted data + feedback).

Details

Your task is to do a global review and carefully refactor this code.

  • see http://paste.pocoo.org/show/300034/ (old code at top, new at bottom)

  • check if we have unwanted redirects after error
  • if some place is unclear, discuss it with moin devs
  • try your code after changing

Deliverables: patch or changeset(s)

Benefits

Less code duplication.

Skill Requirements

See tags. We expect some python / jinja2 coding experience and that you are doing this thoroughly and carefully.

Note: unless otherwise noted, tasks usually refer to moin2 (http://moinmo.in/MoinMoin2.0)!

You can discuss this issue in the MoinMoin wiki: http://moinmo.in/EasyToDo/refactor%20views%20render%20calls