reimplement timings display using logging
completed by: Julian Brost
mentors: Alexander Schremmer, ReimarBauer, Thomas Waldmann, Diógenes Augusto Fernandes Hermínio, Ronny Pfannschmidt
The current "show_timings" footer (on the web ui) should be removed and code adapted so it logs the timings.
Timings are mostly for debugging, tuning, performance monitoring, so not needed on the web ui.
- remove show_timings stuff from layout.html template
- remove show_timings config setting
- log timings using logging functionality, locate this code in some specific module so we can configure log level for it using logging configuration
- look at timers code, simplify it
Outputting timings in the layout.html template is a bit problematic as timers are still running when it is rendered. But as view functions usually end with the template rendering call and also creation of output ends with that, it can only be implemented there as it is now.
But if we just output timer values to the logging system when the timers get stopped, this is much simpler and makes the template cleaner.
The timers code can maybe also get a bit simpler.
And one can look up the timings in the log later, no need to look at the wiki in "realtime" to get timings.
See tags. Python, logging stdlib module.
http://hg.moinmo.in/moin/2.0-dev repository of moin2
You can discuss this issue in the MoinMoin wiki: http://moinmo.in/EasyToDo/reimplement%20timings%20display%20using%20logging